Watch your Manifest. Lin Wang | Android Efficiency Engineer | by Pinterest Engineering | Pinterest Engineering Weblog

Lin Wang | Android Efficiency Engineer

Black magnifying glass with “</” inside of the glass portion and “manifest >” to the right of the magnifying glass

It’s a well known reality for Android builders that an app’s manifest (AndroidManifest.xml) holds essential utility declarations. It’s hardly ever monitored after being arrange as a result of we assume it rarely adjustments. At Pinterest, nonetheless, now we have been actively monitoring the manifest after realizing it does change from time to time.

Whereas constructing an app, Gradle downloads all of the dependent libraries to compile and hyperlink them with the app. These dependent libraries every have their very own mini manifest. Through the construct course of, Android Gradle Plugin (AGP) merges them with the app’s fundamental manifest to type the ultimate manifest. Due to this merging course of, the ultimate manifest typically appears to be like fairly totally different from the unique one and comprises further declarations. Usually, these further declarations are crucial for dependent libraries to operate. Nevertheless, typically they will have unintended behaviors.

It first caught our consideration throughout a chilly begin regression investigation. We discovered a third social gathering Software program Growth Package (SDK) declaring a particular ContentProvider in its manifest to heat up itself as early as potential. It is because content material suppliers get initialized very early in the course of the utility startup, even earlier than the Utility’s onCreate() technique is invoked. Nevertheless, we need to management each third social gathering libraries’ initialization and solely initialize them when it’s crucial. Subsequently, we added the next declaration:

<provider android:name=”com.company.SdkEarlyInitializer” … other android properties … tools:node=”remove”/>

Including this declaration to the manifest will trigger the SdkEarlyInitializer to be faraway from the ultimate merged manifest. This transformation resulted in a chilly begin enchancment of 130ms.

From then on, we created the next course of to repeatedly monitor the merged manifest adjustments earlier than touchdown a commit, beginning with taking a snapshot of the present merged manifest and retaining it within the codebase:

  1. As a part of the PR construct, we examine the merged manifest in opposition to the snapshot.
  2. If a distinction is detected, we fail the construct.
  3. The PR developer should then alter the snapshot manifest if the adjustments are crucial, or add the right “take away” tags to maintain the brand new parts out of the ultimate manifest.

A small group of blocking reviewers will evaluation each manifest change.

  • Found the WorkManagerInitializer (ContentProvider), which was added by the work supervisor library. We firstly eliminated it and notified Google, who ultimately added help for initializing the work supervisor with a custom configuration.
  • Discovered a brand new intent was added by upgrading of the exoplayer library to 2.15.0. We then contributed to the continued issue discussion with Google to lastly have this pointless intent eliminated.
  • Detected the AD_ID permission was added by a library.
  • The common cshell diff is adequate to check manifests
  • AGP does typically reorder the objects in manifest with out altering the content material, through which case the snapshot must be adjusted
  • Ignoring white areas and newlines is important
  • Steadily modified objects within the manifest should be explicitly ignored (e.g. UUIDs, model codes)

With this method, we can be alerted when any new element will get added to our app and really feel extra assured at any time when we add new dependencies.

Android Efficiency Group: Arun Ok, Ernesto Duhart, Lin Wang, Sheng Liu, Tom Harman

Particular Thanks: Sha Sha Chu (She Her)

To study extra about engineering at Pinterest, take a look at the remainder of our Engineering Weblog and go to our Pinterest Labs web site. To discover life at Pinterest, go to our Careers web page.